You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "BenediktRamsauer (via GitHub)" <gi...@apache.org> on 2023/02/10 18:27:02 UTC
[GitHub] [airflow] BenediktRamsauer opened a new pull request, #29467: Fix sftp sensor with pattern
BenediktRamsauer opened a new pull request, #29467:
URL: https://github.com/apache/airflow/pull/29467
This PR will solve the issue registered by @RishuGuru in #28121.
It also takes into account the request from @potiuk in #28123 to add/fix the unit tests.
In summary, the SFTP Sensor was not finding the files when the `file_pattern` argument was used.
This was due to an incorrect assumption that the SFTP Hook function `get_file_by_pattern` would return the full path, where actually it only returns the file name (corrected in e08a702b508e01c8437e4a45eaa726bb39e4f47f).
The unit test that was checking that also made this assumption (corrected in 018f316f96ed5f6361eea59987996454ced73bc7).
closes: #28121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29467: Fix sftp sensor with pattern
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29467:
URL: https://github.com/apache/airflow/pull/29467#issuecomment-1426182040
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29467: Fix sftp sensor with pattern
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29467:
URL: https://github.com/apache/airflow/pull/29467#issuecomment-1428838811
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BenediktRamsauer commented on pull request #29467: Fix sftp sensor with pattern
Posted by "BenediktRamsauer (via GitHub)" <gi...@apache.org>.
BenediktRamsauer commented on PR #29467:
URL: https://github.com/apache/airflow/pull/29467#issuecomment-1426668047
Sorry guys, I made a mistake trying to upgrade my branch to the latest changes in `apache:main`
I will also solve the unsuccessful tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #29467: Fix sftp sensor with pattern
Posted by "dimberman (via GitHub)" <gi...@apache.org>.
dimberman merged PR #29467:
URL: https://github.com/apache/airflow/pull/29467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org