[GitHub] [geode] jdeppe-pivotal opened a new pull request #6113: GEODE-9021: Remove unnecessary buffer allocation in redis Coder

[GitBox <gi...@apache.org>]

jdeppe-pivotal opened a new pull request #6113:
URL: https://github.com/apache/geode/pull/6113


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] upthewaterspout commented on a change in pull request #6113: GEODE-9021: Remove unnecessary buffer allocation in redis Coder

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #6113:
URL: https://github.com/apache/geode/pull/6113#discussion_r592813594



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/RedisResponse.java
##########
@@ -52,59 +52,59 @@ public void afterWrite() {
   }
 
   public ByteBuf encode(ByteBufAllocator allocator) {
-    return coderCallback.apply(allocator);
+    return coderCallback.apply(allocator.buffer());

Review comment:
       At some point I want to push this allocation further up the stack. I believe this ends up being safe because we always pass the returned before to a netty method which will end up freeing it. But I would prefer if it was always clear when we allocate a buffer that it will be freed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal merged pull request #6113: GEODE-9021: Remove unnecessary buffer allocation in redis Coder

[GitBox <gi...@apache.org>]

jdeppe-pivotal merged pull request #6113:
URL: https://github.com/apache/geode/pull/6113


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org