You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/05/23 12:50:12 UTC
[GitHub] [accumulo] dlmarion opened a new pull request, #3422: Fix Long overflow in Retry when backoff factor > 1.0
dlmarion opened a new pull request, #3422:
URL: https://github.com/apache/accumulo/pull/3422
Closes #3414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #3422: Fix Long overflow in Retry when backoff factor > 1.0
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on PR #3422:
URL: https://github.com/apache/accumulo/pull/3422#issuecomment-1559390277
This may prevent the overflow, but I was reviewing this to see if the wait / backoff factor is what is expected when this was merged. Where
```
currentWait = Math.min(maxWait, initialWait + waitIncrement);
```
should it be something like
```
currentWait = Math.min(maxWait, currentWait + waitIncrement);
```
If you have an initial wait of 10 seconds and then you want to retry every second with a back off I would expect wait times like 10, 11, 13, 17,... But it appears that the code would be like 10, 21, 33 (or something), but basically backing off by the initialWait and the back-off increment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #3422: Fix Long overflow in Retry when backoff factor > 1.0
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #3422:
URL: https://github.com/apache/accumulo/pull/3422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3422: Fix Long overflow in Retry when backoff factor > 1.0
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #3422:
URL: https://github.com/apache/accumulo/pull/3422#issuecomment-1559415267
So, two bugs in our Retry object then? Maybe if we are going to touch this again, instead of fixing it we rip it out and replace it with one of:
https://curator.apache.org/apidocs/org/apache/curator/retry/ExponentialBackoffRetry.html
http://rholder.github.io/guava-retrying/
https://resilience4j.readme.io/v1.7.0/docs/retry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org