[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24640: [SPARK-27770] [SQL] Port AGGREGATES.sql [Part 1]

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24640: [SPARK-27770] [SQL]  Port AGGREGATES.sql [Part 1]
URL: https://github.com/apache/spark/pull/24640#discussion_r287017891
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
 ##########
 @@ -109,7 +109,7 @@ trait CheckAnalysis extends PredicateHelper {
 
         operator transformExpressionsUp {
           case a: Attribute if !a.resolved =>
-            val from = operator.inputSet.map(_.qualifiedName).mkString(", ")
+            val from = operator.inputSet.toSeq.map(_.qualifiedName).mkString(", ")
 
 Review comment:
   Got it. Now, this becomes non `[TEST]` and this fix is described in the PR description. Looks good.
   > This PR also fixes the error message when the column can't be resolved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org