You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/17 20:13:11 UTC
Review Request 72783: Added RE2 to the automake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72783/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10170
https://issues.apache.org/jira/browse/MESOS-10170
Repository: mesos
Description
-------
This is a prerequisite to implementing regex-based offer constaints.
Diffs
-----
3rdparty/Makefile.am c277627ced18583868a3e50ed87f4a0ad69cddfb
3rdparty/versions.am 6f6195d8c616695f2077c6c36d96071360b1abb7
configure.ac a049945bd1611e0a23a9e327dd8df3b8dbd902d4
src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
Diff: https://reviews.apache.org/r/72783/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72783: Added RE2 to the automake build.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72783/#review221649
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 18, 2020, 7:01 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72783/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2020, 7:01 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10170
> https://issues.apache.org/jira/browse/MESOS-10170
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a prerequisite to implementing regex-based offer constaints.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am c277627ced18583868a3e50ed87f4a0ad69cddfb
> 3rdparty/versions.am 6f6195d8c616695f2077c6c36d96071360b1abb7
> configure.ac a049945bd1611e0a23a9e327dd8df3b8dbd902d4
> src/Makefile.am 6d68ed050f99889c142d49bbc72a9292ef64c836
> src/python/native_common/ext_modules.py.in 38e6717ec3b7bb09cfbb9b2fa25f173a17d78f51
>
>
> Diff: https://reviews.apache.org/r/72783/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72783: Added RE2 to the automake build.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72783/
-----------------------------------------------------------
(Updated Aug. 18, 2020, 7:01 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Added passing CXX, CXXFLAGS and unconditional `-fPIC`.
Bugs: MESOS-10170
https://issues.apache.org/jira/browse/MESOS-10170
Repository: mesos
Description
-------
This is a prerequisite to implementing regex-based offer constaints.
Diffs (updated)
-----
3rdparty/Makefile.am c277627ced18583868a3e50ed87f4a0ad69cddfb
3rdparty/versions.am 6f6195d8c616695f2077c6c36d96071360b1abb7
configure.ac a049945bd1611e0a23a9e327dd8df3b8dbd902d4
src/Makefile.am 6d68ed050f99889c142d49bbc72a9292ef64c836
Diff: https://reviews.apache.org/r/72783/diff/2/
Changes: https://reviews.apache.org/r/72783/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko