You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/11 09:23:05 UTC

[GitHub] [airflow] potiuk opened a new pull request #7691: [AIRFLOW-7041] make bowler dependency local

potiuk opened a new pull request #7691: [AIRFLOW-7041] make bowler dependency local
URL: https://github.com/apache/airflow/pull/7691
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7691: [AIRFLOW-7041] make bowler dependency local

Posted by GitBox <gi...@apache.org>.

nuclearpinguin commented on a change in pull request #7691: [AIRFLOW-7041] make bowler dependency local
URL: https://github.com/apache/airflow/pull/7691#discussion_r390868604
 
 

 ##########
 File path: backport_packages/setup_backport_packages.py
 ##########
 @@ -143,6 +139,22 @@ def run(self):
 
 
 def change_import_paths_to_deprecated():
+    from bowler import LN, TOKEN, BowlerTool, Capture, Filename, Query
+    from fissix.pytree import Leaf
+
+    BowlerTool.IN_PROCESS = True
 
 Review comment:
   I think we can remove it, now we know that the problem was the `for` loop not multiprocessing 
   ```suggestion
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #7691: [AIRFLOW-7041] make bowler dependency local

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #7691: [AIRFLOW-7041] make bowler dependency local
URL: https://github.com/apache/airflow/pull/7691
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7691: [AIRFLOW-7041] make bowler dependency local

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #7691: [AIRFLOW-7041] make bowler dependency local
URL: https://github.com/apache/airflow/pull/7691#issuecomment-597598369
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=h1) Report
   > Merging [#7691](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2536b517e6b8d9b54289beb7d0da4fee809e0fb5?src=pr&el=desc) will **decrease** coverage by `0.33%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7691/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7691      +/-   ##
   ==========================================
   - Coverage   86.98%   86.65%   -0.34%     
   ==========================================
     Files         904      904              
     Lines       43736    43736              
   ==========================================
   - Hits        38045    37899     -146     
   - Misses       5691     5837     +146
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.75% <0%> (-1.41%)` | :arrow_down: |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.53% <0%> (-0.15%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=footer). Last update [2536b51...e1365b8](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7691: [AIRFLOW-7041] make bowler dependency local

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7691: [AIRFLOW-7041] make bowler dependency local
URL: https://github.com/apache/airflow/pull/7691#issuecomment-597598369
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=h1) Report
   > Merging [#7691](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2536b517e6b8d9b54289beb7d0da4fee809e0fb5&el=desc) will **decrease** coverage by `25.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7691/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7691       +/-   ##
   ===========================================
   - Coverage   86.98%   61.00%   -25.98%     
   ===========================================
     Files         904      904               
     Lines       43736    43736               
   ===========================================
   - Hits        38045    26683    -11362     
   - Misses       5691    17053    +11362     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/oracle/hooks/oracle.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb3JhY2xlL2hvb2tzL29yYWNsZS5weQ==) | `9.40% <0.00%> (-86.33%)` | :arrow_down: |
   | [airflow/providers/apache/sqoop/hooks/sqoop.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3Nxb29wL2hvb2tzL3Nxb29wLnB5) | `11.61% <0.00%> (-83.88%)` | :arrow_down: |
   | [airflow/providers/apache/spark/hooks/spark\_jdbc.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmMucHk=) | `10.34% <0.00%> (-81.61%)` | :arrow_down: |
   | [airflow/providers/slack/hooks/slack\_webhook.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc2xhY2svaG9va3Mvc2xhY2tfd2ViaG9vay5weQ==) | `16.66% <0.00%> (-79.17%)` | :arrow_down: |
   | [...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=) | `21.33% <0.00%> (-78.67%)` | :arrow_down: |
   | [airflow/providers/google/cloud/hooks/dlp.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2RscC5weQ==) | `20.93% <0.00%> (-77.62%)` | :arrow_down: |
   | [airflow/providers/google/suite/hooks/drive.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL3N1aXRlL2hvb2tzL2RyaXZlLnB5) | `22.91% <0.00%> (-77.09%)` | :arrow_down: |
   | [airflow/providers/apache/pig/hooks/pig.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3BpZy9ob29rcy9waWcucHk=) | `18.60% <0.00%> (-76.75%)` | :arrow_down: |
   | [airflow/providers/apache/spark/hooks/spark\_sql.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX3NxbC5weQ==) | `13.63% <0.00%> (-75.76%)` | :arrow_down: |
   | [...rflow/providers/apache/spark/hooks/spark\_submit.py](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX3N1Ym1pdC5weQ==) | `9.19% <0.00%> (-75.48%)` | :arrow_down: |
   | ... and [294 more](https://codecov.io/gh/apache/airflow/pull/7691/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=footer). Last update [2536b51...e1365b8](https://codecov.io/gh/apache/airflow/pull/7691?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services