You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/03/04 08:08:14 UTC
[PR] [SPARK-47266][CONNECT] Make `ProtoUtils.abbreviate` return the same type as the input [spark]
zhengruifeng opened a new pull request, #45369:
URL: https://github.com/apache/spark/pull/45369
### What changes were proposed in this pull request?
Make `ProtoUtils.abbreviate` return the same type as the input
### Why are the changes needed?
existing implementation always return the superclass `Message` (e.g. `proto.Relation` -> `Message`),
while this method actually can return the same type (e.g. `proto.Relation` -> `proto.Relation`).
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
updated tests
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47266][CONNECT] Make `ProtoUtils.abbreviate` return the same type as the input [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #45369: [SPARK-47266][CONNECT] Make `ProtoUtils.abbreviate` return the same type as the input
URL: https://github.com/apache/spark/pull/45369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47266][CONNECT] Make `ProtoUtils.abbreviate` return the same type as the input [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45369:
URL: https://github.com/apache/spark/pull/45369#issuecomment-1976055682
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org