You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/01 01:16:04 UTC

[GitHub] [arrow-datafusion] houqp opened a new pull request #802: show prettier diff in CI

houqp opened a new pull request #802:
URL: https://github.com/apache/arrow-datafusion/pull/802


   
    # Rationale for this change
   
   It's hard to tell what's offending prettier from CI output. Showing the expected change from prettier should help make it easier for contributor to fix CI issues.
   
   # What changes are included in this PR?
   
   Invoke prettier with `--write`, then use `git diff --exit-code` to show diff and fail CI if there is any change produced.
   
   # Are there any user-facing changes?
   
   no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp commented on pull request #802: show prettier diff in CI

Posted by GitBox <gi...@apache.org>.

houqp commented on pull request #802:
URL: https://github.com/apache/arrow-datafusion/pull/802#issuecomment-890436733


   FYI @Jimexist 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #802: show prettier diff in CI

Posted by GitBox <gi...@apache.org>.

alamb merged pull request #802:
URL: https://github.com/apache/arrow-datafusion/pull/802


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org