You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/22 10:20:00 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1115: [CELEBORN-167] Enable JDK 11 for CI.
FMX opened a new pull request, #1115:
URL: https://github.com/apache/incubator-celeborn/pull/1115
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1115: [CELEBORN-171] Enable JDK 11 for CI.
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1115:
URL: https://github.com/apache/incubator-celeborn/pull/1115#issuecomment-1366497281
@nafiyAix thanks for point that, you should have the permission to edit the title, you can fix it directly when you find such issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX closed pull request #1115: [CELEBORN-171] Enable JDK 11 for CI.
Posted by GitBox <gi...@apache.org>.
FMX closed pull request #1115: [CELEBORN-171] Enable JDK 11 for CI.
URL: https://github.com/apache/incubator-celeborn/pull/1115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1115: [CELEBORN-167] Enable JDK 11 for CI.
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #1115:
URL: https://github.com/apache/incubator-celeborn/pull/1115#discussion_r1055510395
##########
.github/workflows/maven.yml:
##########
@@ -46,6 +46,7 @@ jobs:
matrix:
java:
- 8
+ - 11
Review Comment:
Emm... maybe enable Java 11 on service first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1115: [CELEBORN-167] Enable JDK 11 for CI.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1115:
URL: https://github.com/apache/incubator-celeborn/pull/1115#issuecomment-1362668384
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1115?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1115](https://codecov.io/gh/apache/incubator-celeborn/pull/1115?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8bc9ecd) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/bf97a2227be2657d778d488f8a918b15b452e793?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf97a22) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1115 +/- ##
============================================
+ Coverage 27.15% 27.15% +0.01%
Complexity 764 764
============================================
Files 195 195
Lines 16782 16783 +1
Branches 1814 1814
============================================
+ Hits 4555 4556 +1
Misses 11924 11924
Partials 303 303
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `80.56% <0.00%> (+0.02%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] nafiyAix commented on pull request #1115: [CELEBORN-167] Enable JDK 11 for CI.
Posted by GitBox <gi...@apache.org>.
nafiyAix commented on PR #1115:
URL: https://github.com/apache/incubator-celeborn/pull/1115#issuecomment-1364467455
Hi i think this title may link to the wrong issue, the issue may be the [CELEBORN-171](https://issues.apache.org/jira/browse/CELEBORN-171)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org