[GitHub] [helix] jiajunwang commented on a change in pull request #1619: Allow cutomizing default rebalance configuration for the supercluster resources.

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1619:
URL: https://github.com/apache/helix/pull/1619#discussion_r564018113



##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -167,6 +173,14 @@
   private static final int GLOBAL_TARGET_TASK_THREAD_POOL_SIZE_NOT_SET = -1;
   private static final int OFFLINE_NODE_TIME_OUT_FOR_MAINTENANCE_MODE_NOT_SET = -1;
 
+  private static final Map<String, String> DEFAULT_SUPER_CLUSTER_REBALANCE_CONFIG = ImmutableMap
+      .of(RebalanceConfig.RebalanceConfigProperty.REBALANCE_MODE.name(),
+          RebalanceConfig.RebalanceMode.FULL_AUTO.name(),
+          RebalanceConfig.RebalanceConfigProperty.REBALANCER_CLASS_NAME.name(),
+          DelayedAutoRebalancer.class.getName(),

Review comment:
       We cannot change the existing default behavior. So this PR is to add the configuration item to make WAGED default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org