You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "hookokoko (via GitHub)" <gi...@apache.org> on 2023/12/24 10:12:40 UTC
[PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
hookokoko opened a new pull request, #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603
<!-- Thanks for sending a pull request!
-->
**What this PR does**: upgrage dubbogo to 3.1.0
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
1. 依赖的dubbogo的health.proto的pakagename冲突（protocol/triple/health/triple_health/health.proto）
2. registryUrl.Protocol的问题（registry/protocol/protocol.go）
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1902622695
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1925818854
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1925823253
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "hookokoko (via GitHub)" <gi...@apache.org>.
hookokoko closed pull request #603: upgrade dubbogo version: 3.1.0
URL: https://github.com/apache/dubbo-go-pixiu/pull/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1869394321
看下为什么找不到依赖 @hookokoko https://github.com/apache/dubbo-go-pixiu/actions/runs/7323061542/job/19956310498?pr=603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "mark4z (via GitHub)" <gi...@apache.org>.
mark4z commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1880044315
@mark4z
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "hookokoko (via GitHub)" <gi...@apache.org>.
hookokoko commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1869670373
> 看下为什么找不到依赖 @hookokoko https://github.com/apache/dubbo-go-pixiu/actions/runs/7323061542/job/19956310498?pr=603
dubbo-pixiu-sample使用的dubbo版本也需要升级一下，3.1.0的dubbogo没dubbo.apache.org/dubbo-go/v3/common/logger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1902675092
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "hookokoko (via GitHub)" <gi...@apache.org>.
hookokoko commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1868483664
```
func (proto *registryProtocol) Refer(url *common.URL) protocol.Invoker {
......
if registryUrl.Protocol == constant.RegistryProtocol {
registryUrl.Protocol = registryUrl.GetParam(constant.RegistryKey, "")
}
......
```
在跑pixiu sample中的body例子时，dubbogo
3.1.0版本中会将registryUrl.Protocol设置为service-discovery-registry，上面if分支中应该需要额外一个判断：
```if registryUrl.Protocol == constant.RegistryProtocol || registryUrl.Protocol == "service-discovery-registry" {...}```
不然找不到registry对象
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#discussion_r1435818932
##########
pixiu/pkg/config/xds/apiclient/grpc_envoy.go:
##########
@@ -24,7 +24,7 @@ import (
)
import (
- "dubbo.apache.org/dubbo-go/v3/common/logger"
Review Comment:
用的pixiu日志没问题
##########
pixiu/pkg/config/xds/apiclient/grpc_envoy.go:
##########
@@ -24,7 +24,7 @@ import (
)
import (
- "dubbo.apache.org/dubbo-go/v3/common/logger"
Review Comment:
用的pixiu日志没问题
##########
pixiu/pkg/config/xds/apiclient/grpc_envoy.go:
##########
@@ -24,7 +24,7 @@ import (
)
import (
- "dubbo.apache.org/dubbo-go/v3/common/logger"
Review Comment:
用的pixiu日志没问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "hookokoko (via GitHub)" <gi...@apache.org>.
hookokoko commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1869672908
很奇怪，commit的时候看着ci是通过了。不过，按道理integrate test那里应该都过不去哇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1868481451
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#discussion_r1435803596
##########
pixiu/pkg/config/xds/apiclient/grpc_envoy.go:
##########
@@ -24,7 +24,7 @@ import (
)
import (
- "dubbo.apache.org/dubbo-go/v3/common/logger"
Review Comment:
这个没必要改动吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1890915218
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1902674630
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1868508112
pls fix ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1869047799
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1925740037
pls fix conflicts,bro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] upgrade dubbogo version: 3.1.0 [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #603:
URL: https://github.com/apache/dubbo-go-pixiu/pull/603#issuecomment-1925814394
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=603&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org