[jira] [Issue Comment Edited] (NUTCH-1078) Upgrade all instances of commons logging to slf4j (with log4j backend)

["Markus Jelsma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085789#comment-13085789 ] 

Markus Jelsma edited comment on NUTCH-1078 at 8/16/11 3:49 PM:
---------------------------------------------------------------

{quote}
the FATAL level is not supported.

You have to convert them manually. This is limitation is not deemed very serious because there are usually very few log statements bearing the FATAL level. 
{quote}

{code}
    [javac] /home/markus/projects/apache/nutch/branches/branch-1.4/src/java/org/apache/nutch/fetcher/Fetcher.java:531: cannot find symbol
    [javac] symbol  : method fatal(java.lang.String,java.io.IOException)
    [javac] location: interface org.slf4j.Logger
    [javac]               LOG.fatal("QueueFeeder error reading input, record " + cnt, e);
    [javac]                  ^
    [javac] /home/markus/projects/apache/nutch/branches/branch-1.4/src/java/org/apache/nutch/fetcher/Fetcher.java:788: cannot find symbol
    [javac] symbol  : method isFatalEnabled()
    [javac] location: interface org.slf4j.Logger
    [javac]         if (LOG.isFatalEnabled()) {
{code}

A lot of errors about these two fatal methods.


      was (Author: markus17):
    Strange:

{code}
    [javac] /home/markus/projects/apache/nutch/branches/branch-1.4/src/java/org/apache/nutch/fetcher/Fetcher.java:531: cannot find symbol
    [javac] symbol  : method fatal(java.lang.String,java.io.IOException)
    [javac] location: interface org.slf4j.Logger
    [javac]               LOG.fatal("QueueFeeder error reading input, record " + cnt, e);
    [javac]                  ^
    [javac] /home/markus/projects/apache/nutch/branches/branch-1.4/src/java/org/apache/nutch/fetcher/Fetcher.java:788: cannot find symbol
    [javac] symbol  : method isFatalEnabled()
    [javac] location: interface org.slf4j.Logger
    [javac]         if (LOG.isFatalEnabled()) {
{code}

A lot of errors about these two fatal methods.

  
> Upgrade all instances of commons logging to slf4j (with log4j backend)
> ----------------------------------------------------------------------
>
>                 Key: NUTCH-1078
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1078
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.4, 2.0
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 1.4, 2.0
>
>         Attachments: NUTCH-1078-branch-1.4-20110816.patch
>
>
> Whilst working on another issue, I noticed that some classes still import and use commons logging for example HttpBase.java
> {code}
> import java.util.*;
> // Commons Logging imports
> import org.apache.commons.logging.Log;
> import org.apache.commons.logging.LogFactory;
> // Nutch imports
> import org.apache.nutch.crawl.CrawlDatum;
> {code}
> At this stage I am unsure how many (if any others) still import and reply upon commons logging, however they should be upgraded to slf4j for branch-1.4.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira