You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/29 21:37:57 UTC

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1145: HDDS-3895. Implement container related operations in ContainerManagerImpl

xiaoyuyao commented on a change in pull request #1145:
URL: https://github.com/apache/hadoop-ozone/pull/1145#discussion_r447268958



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java
##########
@@ -279,6 +257,24 @@ public void notifyContainerReportProcessing(final boolean isFullReport,
     throw new UnsupportedOperationException("Not yet implemented!");
   }
 
+  @Override
+  public void deleteContainer(final ContainerID containerID)
+      throws IOException {
+    final HddsProtos.ContainerID id = containerID.getProtobuf();

Review comment:
       Need to hold the writeLock?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org