[jira] [Commented] (CMIS-809) cmislib applyACL method has multiple issues

["Jeff Potts (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CMIS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017269#comment-14017269 ] 

Jeff Potts commented on CMIS-809:
---------------------------------

I see now that the AtomPub binding is supposed to accept a PUT of the XML representing the state of the ACL the caller wants to set. So the original implementation approach is okay, but there are still definitely issues. I'm looking into it now.

The BrowserBinding will need to accept the add ACE and remove ACE lists. I'll implement it to minimize the difference in the API between the two bindings.

As a side-note, as part of investigating this I may have found a bug in Alfresco related to ACLs, logged here: https://issues.alfresco.com/jira/browse/ALF-20978

> cmislib applyACL method has multiple issues
> -------------------------------------------
>
>                 Key: CMIS-809
>                 URL: https://issues.apache.org/jira/browse/CMIS-809
>             Project: Chemistry
>          Issue Type: Bug
>          Components: python-cmislib
>    Affects Versions: cmislib 0.5.1
>            Reporter: Jeff Potts
>            Assignee: Jeff Potts
>
> The testApplyACL() unit test is failing against Apache Chemistry 0.11.0. In addition, certain use cases are not handled properly, such as adding two different permissions for the same principal. Currently only the last one in the ACL is applied.
> This was originally implemented by accepting an ACL object that represented the ACL the caller wanted on the document, then doing a PUT against the object's ACL.
> On further review of the spec, the applyACL method should be refactored to accept an add list and a remove list. As part of this, the case where duplicate principals are added to the same list needs to be incorporated.
> The unit test could also be beefed up.



--
This message was sent by Atlassian JIRA
(v6.2#6252)