[jira] [Comment Edited] (LOG4J2-2417) Better handling of optional properties

["Andrei Ivanov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623299#comment-16623299 ] 

Andrei Ivanov edited comment on LOG4J2-2417 at 9/21/18 9:09 AM:
----------------------------------------------------------------

[~ralph.goers@dslextreme.com] I've created PRs for some of the tickets.
Any chance you could review them?
I hope to get them merged and then to start with the other tichets :)


was (Author: shadow):
[~ralph.goers@dslextreme.com] I've created PRs for some of the tickets?
Any chance you could review them?
I hope to get them merged and then to start with the other tichets :)

> Better handling of optional properties
> --------------------------------------
>
>                 Key: LOG4J2-2417
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2417
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Log4j-Audit
>    Affects Versions: Log4j-Audit 1.0.0
>            Reporter: Andrei Ivanov
>            Assignee: Ralph Goers
>            Priority: Minor
>
> The Log4j-Audit project page indicates this as the place to file tickets, but I don't see the 1.0.0 version for it.
> Investigating the use of the project, I started with a basic `catalog.json`, with just an event and 2 attributes, both with {{requestContext = false}}.
> {noformat}
> java.lang.NullPointerException
> 	at org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
> 	at org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
> 	at org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
> 	at org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)
> {noformat}
> As far as I understand, request context attributes are not required.
>  ??While usage of a RequestContext is not required, the use of one should be considered a best practice.??
> Also, AFAIU, the event attributes should also be optional, there's even a test event *login* like that.
> Also the code seems to indicate that {{@MaxLength}} should also be optional, same as {{@RequestContext}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)