You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2023/01/30 15:10:25 UTC

[GitHub] [maven-build-cache-extension] gnodet commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions

gnodet commented on code in PR #34:
URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1090750483


##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -594,7 +595,7 @@ public String getId()
     public String getUrl()
     {
         checkInitializedState();
-        return getRemote().getUrl();
+        return getProperty( REMOTE_URL_PROPERTY_NAME, getRemote().getUrl() );

Review Comment:
   Can we split that in a different commit if that's unrelated ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org