You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/03 17:49:40 UTC

[GitHub] [incubator-tvm] electriclilies commented on a change in pull request #6353: [RELAY][DYN] Dynamic UpSampling3D Op

electriclilies commented on a change in pull request #6353:
URL: https://github.com/apache/incubator-tvm/pull/6353#discussion_r483153389



##########
File path: python/tvm/relay/op/dyn/nn/_nn.py
##########
@@ -47,12 +61,12 @@ def compute_upsampling(attrs, inputs, out_dtype):
 
 # upsampling
 @script
-def _upsampling_shape_func(dshape, scale_h, scale_w, height_axis, width_axis, channel_axis):

Review comment:
       It's an unnecessary argument. We've already copied the channel axis in the loop, and since we don't modify that axis, we don't need to recopy it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org