[GitHub] [airflow] mcreenan commented on issue #16972: AWS Hooks fail when assuming role and connection id contains forward slashes

[GitBox <gi...@apache.org>]

mcreenan commented on issue #16972:
URL: https://github.com/apache/airflow/issues/16972#issuecomment-879275854


   > Are you willing to submit a PR? I'm happy to help with review.
   
   That may be something I can start on next week.
   
   I'd appreciate input on solutions.
   
   My initial thought is there are 2 possible solutions, either implementing only 1 of them or implementing both.
   
   1.  Remove all characters that don't match the regular expression pattern ([\w+=,.@-]*) OR replace them with hyphens
   2. Add an option that allows you to specify a custom role session name in the aws connection uri (e.g. `role_session_name=foo`) -- but I'm not terrible familiar with that code to know if that's the best way to handle it or how complex the change would be


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org