You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/29 05:12:02 UTC
[GitHub] [flink] dugenkui03 opened a new pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
dugenkui03 opened a new pull request #13277:
URL: https://github.com/apache/flink/pull/13277
## What is the purpose of the change
1. Replace `ReentrantLock` with `ReentrantReadWriteLock` to improve concurrency;
2. Use `signal` instead of `signalAll` to reduce the thread scheduling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6be96d65aff9af67e8af0a2cb3edf68cc084940 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dugenkui03 commented on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
dugenkui03 commented on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-684804553
hi @JingsongLi @wuchong , would you help me review this, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
}, {
"hash" : "d27a55972f2461d7504a73b85074523b8a55638f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981",
"triggerID" : "d27a55972f2461d7504a73b85074523b8a55638f",
"triggerType" : "PUSH"
}, {
"hash" : "d3243272d6a5ff0f2a5378e302338293463da8d2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3243272d6a5ff0f2a5378e302338293463da8d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d27a55972f2461d7504a73b85074523b8a55638f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981)
* d3243272d6a5ff0f2a5378e302338293463da8d2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683238576
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 22af70e728f6824a4c6a11d208ef6bea56318c3e (Sat Aug 29 05:13:28 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19089).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
}, {
"hash" : "d27a55972f2461d7504a73b85074523b8a55638f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981",
"triggerID" : "d27a55972f2461d7504a73b85074523b8a55638f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6be96d65aff9af67e8af0a2cb3edf68cc084940 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980)
* d27a55972f2461d7504a73b85074523b8a55638f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dugenkui03 commented on a change in pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
dugenkui03 commented on a change in pull request #13277:
URL: https://github.com/apache/flink/pull/13277#discussion_r481163983
##########
File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/ClosableBlockingQueue.java
##########
@@ -176,17 +178,17 @@ public boolean close() {
public boolean addIfOpen(E element) {
requireNonNull(element);
- lock.lock();
+ writeLock.lock();
try {
if (open) {
elements.addLast(element);
if (elements.size() == 1) {
- nonEmpty.signalAll();
+ nonEmpty.signal();
Review comment:
`signal()` is safe and reasonable, since all the threads which waiting on the `nonEmpty` Condition wish to take element from queue, and at most one thread can get element from queue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dugenkui03 closed pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
dugenkui03 closed pull request #13277:
URL: https://github.com/apache/flink/pull/13277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
}, {
"hash" : "d27a55972f2461d7504a73b85074523b8a55638f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981",
"triggerID" : "d27a55972f2461d7504a73b85074523b8a55638f",
"triggerType" : "PUSH"
}, {
"hash" : "d3243272d6a5ff0f2a5378e302338293463da8d2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5983",
"triggerID" : "d3243272d6a5ff0f2a5378e302338293463da8d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d27a55972f2461d7504a73b85074523b8a55638f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981)
* d3243272d6a5ff0f2a5378e302338293463da8d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5983)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
}, {
"hash" : "d27a55972f2461d7504a73b85074523b8a55638f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981",
"triggerID" : "d27a55972f2461d7504a73b85074523b8a55638f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6be96d65aff9af67e8af0a2cb3edf68cc084940 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980)
* d27a55972f2461d7504a73b85074523b8a55638f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
}, {
"hash" : "d27a55972f2461d7504a73b85074523b8a55638f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981",
"triggerID" : "d27a55972f2461d7504a73b85074523b8a55638f",
"triggerType" : "PUSH"
}, {
"hash" : "d3243272d6a5ff0f2a5378e302338293463da8d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5983",
"triggerID" : "d3243272d6a5ff0f2a5378e302338293463da8d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3243272d6a5ff0f2a5378e302338293463da8d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5983)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6be96d65aff9af67e8af0a2cb3edf68cc084940 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
}, {
"hash" : "d27a55972f2461d7504a73b85074523b8a55638f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d27a55972f2461d7504a73b85074523b8a55638f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6be96d65aff9af67e8af0a2cb3edf68cc084940 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980)
* d27a55972f2461d7504a73b85074523b8a55638f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dugenkui03 removed a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
dugenkui03 removed a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-684804553
hi @JingsongLi @wuchong , would you help me review this, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-683239187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5980",
"triggerID" : "d6be96d65aff9af67e8af0a2cb3edf68cc084940",
"triggerType" : "PUSH"
}, {
"hash" : "d27a55972f2461d7504a73b85074523b8a55638f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981",
"triggerID" : "d27a55972f2461d7504a73b85074523b8a55638f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d27a55972f2461d7504a73b85074523b8a55638f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5981)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dugenkui03 removed a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue
Posted by GitBox <gi...@apache.org>.
dugenkui03 removed a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-684804553
hi @JingsongLi @wuchong , would you help me review this, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org