You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/22 06:59:54 UTC

[GitHub] [pulsar] 315157973 opened a new pull request #10319: Support listenerName for HttpLookupService

315157973 opened a new pull request #10319:
URL: https://github.com/apache/pulsar/pull/10319


   
   ### Motivation
   Support listenerName for http lookup
   
   ### Modifications
   Add listenerName to http API
   
   ### Verifying this change
   1) test lookup
   2) test redirect
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] 315157973 commented on pull request #10319: Support listenerName for HttpLookupService

Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #10319:
URL: https://github.com/apache/pulsar/pull/10319#issuecomment-829913269


   @codelipenghui  PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10319: Support listenerName for HttpLookupService

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10319:
URL: https://github.com/apache/pulsar/pull/10319


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10319: Support listenerName for HttpLookupService

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #10319:
URL: https://github.com/apache/pulsar/pull/10319#discussion_r622786325



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -331,11 +331,21 @@ public String getPersistenceNamingEncoding() {
      * @return
      */
     public String getLookupName() {
+        return getLookupName(null);
+    }
+
+    public String getLookupName(String listenerName) {

Review comment:
       It's better to build the url in the pulsar-admin, it's not suitable to use the TopicName to generate the request URL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org