You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/05 10:54:53 UTC
[GitHub] [maven-wrapper] timtebeek opened a new pull request, #80: [MWRAPPER-33] Adopt Java 8 constructs
timtebeek opened a new pull request, #80:
URL: https://github.com/apache/maven-wrapper/pull/80
Java 8 brought some possible code improvements over the previous Java 7. These have been applied through:
```
mvn org.openrewrite.maven:rewrite-maven-plugin:4.38.2:run -DactiveRecipes=org.openrewrite.java.cleanup.CommonStaticAnalysis
```
With the following results
```
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineParser.java by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.EqualsAvoidsNull
org.openrewrite.java.cleanup.FinalClass
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLineOption.java by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineOption.java by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLine.java by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/AbstractPropertiesCommandLineConverter.java by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper-plugin/src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseLambdaForFunctionalInterface
```
A few private classes have been made final, but I don't suppose that will be an issue.
All of these changes were automated, so I don't feel particularly attached to them/
Feel free to provide honest feedback if these types of changes are not welcome! :)
----
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on pull request #80: [MWRAPPER-33] Adopt Java 8 constructs
Posted by GitBox <gi...@apache.org>.
timtebeek commented on PR #80:
URL: https://github.com/apache/maven-wrapper/pull/80#issuecomment-1373457243
@bmarwell [As discussed](https://github.com/apache/maven-wrapper/pull/61#discussion_r1062397142) I've force pushed to this branch now that the parent and formatting has changed in master. Ready for review & merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on pull request #80: [MWRAPPER-33] Adopt Java 8 constructs
Posted by GitBox <gi...@apache.org>.
timtebeek commented on PR #80:
URL: https://github.com/apache/maven-wrapper/pull/80#issuecomment-1372066485
And a small note perhaps that [the recent shellcheck step](https://github.com/apache/maven-wrapper/commit/ccaa27d6e7db433e6c3e71b3a74985d28bbfcf03) also runs (and fails) on forks, so some changes there might be in order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell merged pull request #80: [MWRAPPER-33] Adopt Java 8 constructs
Posted by GitBox <gi...@apache.org>.
bmarwell merged PR #80:
URL: https://github.com/apache/maven-wrapper/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org