You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2019/01/15 14:08:59 UTC
svn commit: r1851358 -
/subversion/trunk/subversion/tests/libsvn_fs/locks-test.c
Author: brane
Date: Tue Jan 15 14:08:59 2019
New Revision: 1851358
URL: http://svn.apache.org/viewvc?rev=1851358&view=rev
Log:
* subversion/tests/libsvn_fs/locks-test.c (obtain_write_lock_failure):
Add a comment that explains why this test fails when run as root.
No functional change.
Modified:
subversion/trunk/subversion/tests/libsvn_fs/locks-test.c
Modified: subversion/trunk/subversion/tests/libsvn_fs/locks-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_fs/locks-test.c?rev=1851358&r1=1851357&r2=1851358&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_fs/locks-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_fs/locks-test.c Tue Jan 15 14:08:59 2019
@@ -1089,6 +1089,9 @@ lock_cb_error(const svn_test_opts_t *opt
return SVN_NO_ERROR;
}
+/* XXX NOTE:
+ This test will fail on most Unix-like systems when run as the
+ root user, because flock() will ignore file permissions. */
static svn_error_t *
obtain_write_lock_failure(const svn_test_opts_t *opts,
apr_pool_t *pool)