[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2970: fix checkAllLedgersDuration compute

[GitBox <gi...@apache.org>]

nicoloboschi commented on a change in pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#discussion_r781208633



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -786,6 +785,9 @@ public void run() {
                         LOG.error("I/O exception running periodic check", ioe);
                     } catch (ReplicationException.UnavailableException ue) {
                         LOG.error("Underreplication manager unavailable running periodic check", ue);
+                    } finally {
+                        LOG.info("Completed checkAllLedgers in {} milliSeconds", checkAllLedgersDuration);
+                        checkAllLedgersTime.registerSuccessfulEvent(checkAllLedgersDuration, TimeUnit.MILLISECONDS);

Review comment:
       we need to differentiate the if operation completed successfully or not
   
   if an exception occurs we have to call `registerFailedEvent`
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org