[jira] [Commented] (DRILL-3008) Canonicalize Option Names, update calls to use validators rather than names.

["Jason Altekruse (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612632#comment-14612632 ] 

Jason Altekruse commented on DRILL-3008:
----------------------------------------

After applying this patch I have gone through to update the Unit tests to use the new interfaces introduced in this changeset. I wanted to add the ability for Drill to accept both names for a few releases and produce a warning message for anyone using the old name that will be deprecated. The refactoring of the unit tests hits a lot of files, and will only get harder to rebase. I am going to move this issue to just handling the refactoring to remove any references to the option names in the code and tests (replacing them with direct references to the option validators). I will open a new JIRA to rename the options when I finish the enhancement to allow the legacy ones to live alongside the new ones for a few releases and have a good plan in place for deprecating the old names.

> Canonicalize Option Names, update calls to use validators rather than names.
> ----------------------------------------------------------------------------
>
>                 Key: DRILL-3008
>                 URL: https://issues.apache.org/jira/browse/DRILL-3008
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Jacques Nadeau
>            Assignee: Jason Altekruse
>             Fix For: 1.2.0
>
>         Attachments: DRILL-3008.patch
>
>
> Clean up option usages before 1.0:
> - Update the option names to be consistent.
> - Always use type-safe validators rather than direct names in Drill core and testcode.  
> - Update test framework to take validator and setting rather than string
> - Remove all string ALTER SESSION settings in Drill codebase



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)