You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (JIRA)" <ji...@apache.org> on 2019/05/09 09:39:00 UTC

[jira] [Closed] (FLINK-12453) StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator

     [ https://issues.apache.org/jira/browse/FLINK-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jark Wu closed FLINK-12453.
---------------------------
       Resolution: Fixed
    Fix Version/s: 1.9.0

Fixed in 1.9.0: 504e7be7dcb2cad4184f9ffd1ef20d8b13f64f40

> StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-12453
>                 URL: https://issues.apache.org/jira/browse/FLINK-12453
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>            Reporter: Jingsong Lee
>            Assignee: Jark Wu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.9.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In generateAggsHandler: 
> val generator = new AggsHandlerCodeGenerator(
>    CodeGeneratorContext(config),
>    relBuilder,
>    FlinkTypeFactory.toInternalRowType(inputRowType).getFieldTypes,
>    needRetract = false,
>    config.getNullCheck,
>    inputFieldCopy)
> but AggsHandlerCodeGenerator args is:
> class AggsHandlerCodeGenerator(
>    ctx: CodeGeneratorContext,
>    relBuilder: RelBuilder,
>    inputFieldTypes: Seq[InternalType],
>    needRetract: Boolean,
>    copyInputField: Boolean,
>    needAccumulate: Boolean = true)
> Same issue to StreamExecIncrementalGroupAggregate



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)