You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/05/04 02:53:16 UTC

[GitHub] [doris] yiguolei commented on a diff in pull request #19091: [Refact](type system) refact column with arrow serde

yiguolei commented on code in PR #19091:
URL: https://github.com/apache/doris/pull/19091#discussion_r1184491411


##########
be/src/vec/data_types/serde/data_type_string_serde.cpp:
##########
@@ -63,5 +66,62 @@ void DataTypeStringSerDe::read_one_cell_from_jsonb(IColumn& column, const JsonbV
     auto blob = static_cast<const JsonbBlobVal*>(arg);
     col.insert_data(blob->getBlob(), blob->getBlobLen());
 }
+
+void DataTypeStringSerDe::write_column_to_arrow(const IColumn& column, const UInt8* null_map,
+                                                arrow::ArrayBuilder* array_builder, int start,
+                                                int end) const {
+    const auto& string_column = assert_cast<const ColumnString&>(column);
+    auto& builder = assert_cast<arrow::StringBuilder&>(*array_builder);
+    for (size_t string_i = start; string_i < end; ++string_i) {
+        if (null_map && null_map[string_i]) {
+            checkArrowStatus(builder.AppendNull(), column.get_name(),

Review Comment:
   method name should be   check_arrow_status



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org