You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "Francesco Chicchiriccò (JIRA)" <ji...@apache.org> on 2013/09/20 09:32:53 UTC
[jira] [Commented] (SYNCOPE-417) Users are made active when
updating in NoOpWorkflowAdapter
[ https://issues.apache.org/jira/browse/SYNCOPE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772847#comment-13772847 ]
Francesco Chicchiriccò commented on SYNCOPE-417:
------------------------------------------------
Hi Jesse, this looks definitely correct: would you mind to provide a proper patch (some [guidelines|https://commons.apache.org/patches.html] are available, if needed).
> Users are made active when updating in NoOpWorkflowAdapter
> ----------------------------------------------------------
>
> Key: SYNCOPE-417
> URL: https://issues.apache.org/jira/browse/SYNCOPE-417
> Project: Syncope
> Issue Type: Bug
> Components: core
> Affects Versions: 1.1.3
> Reporter: Jesse van Bekkum
> Priority: Minor
> Fix For: 1.1.4, 1.2.0
>
>
> When using the NoOpWorkflow adapter a user is always set to active when an update is done, even if the user is suspended. This is undesirable, I think a user should stay in the state it is.
> This can be fixed by changing this line (117/118 of NoOpWorkflowAdapter.java):
> return new WorkflowResult<Map.Entry<Long, Boolean>>(
> new AbstractMap.SimpleEntry<Long, Boolean>(updated.getId(), true), propByRes, "update");
> into this:
> return new WorkflowResult<Map.Entry<Long, Boolean>>(
> new AbstractMap.SimpleEntry<Long, Boolean>(updated.getId(), !user.isSuspended()), propByRes, "update");
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira