[GitHub] [flink] xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

[GitBox <gi...@apache.org>]

xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8353#issuecomment-490499892
 
 
   > Thanks @xuefuz . The reason I use util methods is because as the logic complexity grows, the size of two catalog classes can be quite big. I'm fine to remove util methods and keep shared logic in HiveCatalogBase and special logic of each catalog in its own class now, and we can reevaluate whenever necessary.
   
   Hi @bowenli86 , use of util class is fine. However, it usually provides static methods to share code between irrelevant classes. It's a also fine to use it to reduce the file size, in which case the methods should be package scope. It seems unusual if we let those util classes form a hierarchy. Just my humble opinion, though.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services