[GitHub] [flink] Myasuka commented on a change in pull request #19106: [FLINK-26560][StateBackends] Make the threshold of the overlap fraction of incremental restoring configurable

[GitBox <gi...@apache.org>]

Myasuka commented on a change in pull request #19106:
URL: https://github.com/apache/flink/pull/19106#discussion_r827793957



##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
##########
@@ -255,6 +255,15 @@
                             "If true, RocksDB will use block-based filter instead of full filter, this only take effect when bloom filter is used. "
                                     + "The default value is 'false'.");
 
+    public static final ConfigOption<Double> RESTORE_OVERLAP_FRACTION_THRESHOLD =
+            key("state.backend.rocksdb.restore-overlap-fraction-threshold")
+                    .doubleType()
+                    .defaultValue(0.0)

Review comment:
       In this PR, we should still left this value as `0.75` as before. 

##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java
##########
@@ -33,39 +33,30 @@
 import java.util.Collection;
 import java.util.Comparator;
 import java.util.List;
-import java.util.function.BiFunction;
 
 /** Utils for RocksDB Incremental Checkpoint. */
 public class RocksDBIncrementalCheckpointUtils {
-
-    /**
-     * The threshold of the overlap fraction of the handle's key-group range with target key-group
-     * range to be an initial handle.
-     */
-    private static final double OVERLAP_FRACTION_THRESHOLD = 0.75;
-
     /**
      * Evaluates state handle's "score" regarding to the target range when choosing the best state
-     * handle to init the initial db for recovery, if the overlap fraction is less than {@link
-     * #OVERLAP_FRACTION_THRESHOLD}, then just return {@code Score.MIN} to mean the handle has no
-     * chance to be the initial handle.
+     * handle to init the initial db for recovery.

Review comment:
       I think the description of `Score` should still stay here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org