[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7090: KVM: revert libvirtd config and retry if fail to add a host

[GitBox <gi...@apache.org>]

weizhouapache commented on code in PR #7090:
URL: https://github.com/apache/cloudstack/pull/7090#discussion_r1071043902


##########
server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java:
##########
@@ -260,10 +260,11 @@ private void setupAgentSecurity(final Connection sshConnection, final String age
 
             final String privateKey = _configDao.getValue("ssh.privatekey");
             if (!SSHCmdHelper.acquireAuthorizedConnectionWithPublicKey(sshConnection, username, privateKey)) {
-                s_logger.error("Failed to authenticate with ssh key");
                 if (org.apache.commons.lang3.StringUtils.isEmpty(password)) {
+                    s_logger.error("Failed to authenticate with ssh key");

Review Comment:
   @DaanHoogland 
   if password is empty, then no retrying, therefore log an error and throw an exception.
   
   if password is not empty, log an info (libne 267) and retrying with password



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org