You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2008/06/06 09:04:00 UTC
[jira] Created: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
JMX Instrumentation - PerformanceCounter - total processed
----------------------------------------------------------
Key: CAMEL-582
URL: https://issues.apache.org/activemq/browse/CAMEL-582
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Affects Versions: 1.3.0
Reporter: Claus Ibsen
Priority: Trivial
Fix For: 1.4.0
William Tam, this one is for you ;)
The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-582:
---------------------------------
Assignee: Claus Ibsen
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-582:
------------------------------
Attachment: jconsole_doubles.PNG
jconsole snapshot will look like this. notice I also appended the "Millis" subfix in the processing time attributes.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
> Attachments: jconsole_doubles.PNG, patch.txt
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-582:
------------------------------
Attachment: (was: patch.txt)
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
> Attachments: jconsole_doubles.PNG, patch.txt
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-582:
------------------------------
Attachment: patch.txt
here is the patch.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
> Attachments: jconsole_doubles.PNG, patch.txt
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43345#action_43345 ]
Claus Ibsen commented on CAMEL-582:
-----------------------------------
Ok good observations. But we should clearly state the value as micro seconds (1000 micro = 1 millis). Most metrics report is still in millis.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43408#action_43408 ]
Claus Ibsen commented on CAMEL-582:
-----------------------------------
Patch to be provided by William, started progress.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43343#action_43343 ]
William Tam commented on CAMEL-582:
-----------------------------------
My thought on this is that having usec attributes is good enough. Having two attributes (usec and millis) for each managed attribute is probably too repetitive. Users can always obtains millis from usec but not the other way around. Also, the TotalProcessed time probably needs to be double since it holds much better value.
So, my suggestion is:
1) roll back to usec and the calculation like we had it before
2) expose TotalProcessed time as a managed attribute
3) keep TotalProcessed time as a double.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43416#action_43416 ]
William Tam commented on CAMEL-582:
-----------------------------------
The patch also fixes a bug in reset() which does not reset minProcessingTime back to -1. And, maxProcessingTime does not need to be -1.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
> Attachments: jconsole_doubles.PNG, patch.txt
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-582.
-------------------------------
Resolution: Fixed
William thanks a lot for contributing this patch and taking the time to do investigations and good observations.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
> Attachments: jconsole_doubles.PNG, patch.txt
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43308#action_43308 ]
Claus Ibsen commented on CAMEL-582:
-----------------------------------
William.
Okay for the usec, but maybe we should have a derived attribute for the millis as well? eg = read only attribute that displays the values in millis, so the end-user have the information also.
But the internal computation is done using the nano and displayed as usec stuff.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-582:
------------------------------
Attachment: patch.txt
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
> Attachments: jconsole_doubles.PNG, patch.txt
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43412#action_43412 ]
William Tam commented on CAMEL-582:
-----------------------------------
Here's another idea. How about making the values in units of milliseconds but storing them in doubles? This way, values less than one millisecond won't get truncated and we don't scarify the precisions. Values reported are in milliseconds still.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on CAMEL-582 started by Claus Ibsen.
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-582) JMX Instrumentation -
PerformanceCounter - total processed
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43307#action_43307 ]
William Tam commented on CAMEL-582:
-----------------------------------
Hi Claus,
Sure, I will submit a patch to expose TotalProcessed time as a managed attribute and change the type to long.
We've made quite a few changes lately. I think the current precision (millisecond) is not high enough. We often get 0 value when a processor does not have a lot of work to do. Think about when you add up 0's million times, you still get zero for total processed time. :-) How about going back to usec?
> JMX Instrumentation - PerformanceCounter - total processed
> ----------------------------------------------------------
>
> Key: CAMEL-582
> URL: https://issues.apache.org/activemq/browse/CAMEL-582
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Trivial
> Fix For: 1.4.0
>
>
> William Tam, this one is for you ;)
> The total processed time is not exposed to as a managed attribute. And it should be changed from double to long.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.