You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2016/01/25 20:40:38 UTC
[GitHub] activemq-artemis pull request: Disconnect on STOMP 1.2 errors
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/344
Disconnect on STOMP 1.2 errors
As required by the spec: https://stomp.github.io/stomp-specification-1.2.html#ERROR
I'm not particularly happy with the AbstractStompClientConnection change (would be better if it noticed disconnects and sets its state automatically), but it seems to get the job done without breaking other tests. And the Thread.sleep()s are there so that the disconnect has actually happened, not sure if there's a cleaner approach to that ready to be reused somewhere.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis stomp12-disconnect-on-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #344
----
commit 23385f67c92d4dcb475832a6bdcddd056748a65b
Author: Ville Skyttä <vi...@iki.fi>
Date: 2016-01-25T19:01:10Z
Disconnect on STOMP 1.2 errors
https://stomp.github.io/stomp-specification-1.2.html#ERROR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Disconnect on STOMP 1.2 errors
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/344#issuecomment-174782983
I am making a small improvement on the test. just looping through a timeout instead of a sleep (almost the same). We could add something better with a latch but for this test this is good enough I think.
I will merge my commit with yours.. you can amend the test later if you like.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Disconnect on STOMP 1.2 errors
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/344#issuecomment-174778222
Nice one! The complexity of your commits are increasing each day!!! Nice to see that !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Disconnect on STOMP 1.2 errors
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---