[GitHub] [beam] robertwb commented on a change in pull request #11524: [BEAM-9815] Correct go integration test if clauses.

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #11524:
URL: https://github.com/apache/beam/pull/11524#discussion_r415960127



##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -102,9 +102,8 @@ case $key in
 esac
 done
 
-if [[ "$RUNNER" != "universal" ]]; then
-  PUSH_CONTAINER_TO_GCR='yes'
-else
+PUSH_CONTAINER_TO_GCR='yes'

Review comment:
       Isn't it better to avoid double assignment? 

##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -118,7 +117,7 @@ test -d sdks/go/test
 command -v docker
 docker -v
 
-if [[ PUSH_CONTAINER_TO_GCR == 'yes' ]]; then
+if [ "$PUSH_CONTAINER_TO_GCR" = "yes" ]; then

Review comment:
       I used double brackets because that's what was used in the rest of the file. We should be consistent. 

##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -148,7 +147,7 @@ if [[ PUSH_CONTAINER_TO_GCR == 'yes' ]]; then
 
   # Push the container
   gcloud docker -- push $CONTAINER
-else
+else 

Review comment:
       extra space

##########
File path: sdks/go/container/boot.go
##########
@@ -104,7 +104,7 @@ func main() {
 
 	switch len(artifacts) {
 	case 0:
-		log.Fatal("No artifacts staged")
+		log.Printf("No artifacts staged. Attempting to run default \"worker\".")

Review comment:
       Shouldn't this be fatal? There isn't a "default" worker. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org