You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by sh...@apache.org on 2022/06/07 06:47:58 UTC

[rocketmq-eventbridge] 02/02: Optimize http source usage instructions

This is an automated email from the ASF dual-hosted git repository.

shenlin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/rocketmq-eventbridge.git

commit 22f06dc15cba2f96df59291a7b433408bb72c157
Author: changfeng <yo...@alibaba-inc.com>
AuthorDate: Thu May 19 17:06:38 2022 +0800

    Optimize http source usage instructions
---
 README.md                                          | 27 ++++++++++------------
 .../adapter/api/converter/HttpEventConverter.java  |  2 +-
 2 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/README.md b/README.md
index 11c16a4..201d646 100644
--- a/README.md
+++ b/README.md
@@ -148,31 +148,28 @@ http://127.0.0.1:7001/source/createEventSource
 Http request to access this webhook will be converted into a CloudEvent and delivered to eventbus.
 
 ```
-http://127.0.0.1/webhook/putEvents?token=43146d108b2123
-Header: Content-Type:"application/json"
-```
-```json
-{
-  "username": "testUser",
-  "testData": "testData"
-}
+curl -d '{"username": "testUser", "testData": "testData"}' -H 'Content-Type: application/json' -H 'Accept-Language: en-US' http://127.0.0.1:7001/webhook/putEvents?token=43146d108b224eb2adc581aedd28f272007320d14b9d
 ```
+
 generated CloudEvent demo
 ```json
 {
   "datacontenttype": "application/json",
   "data": {
-    "headers": {
-      "Accecpt": "*/*",
-      "Host": "127.0.0.1:7001",
-      "Content-Type": "none"
-    },
-    "path": "/webhook/putEvents",
     "body": {
       "username": "testUser",
       "testData": "testData"
     },
-    "httpMethod": "GET",
+    "headers": {
+      "Accept": "*/*",
+      "User-Agent": "curl/7.64.1",
+      "Host": "127.0.0.1:7001",
+      "Accept-Language": "en-US",
+      "Content-Length": "48",
+      "Content-Type": "application/json"
+    },
+    "httpMethod": "POST",
+    "path": "/webhook/putEvents",
     "queryString": {}
   },
   "subject": "DemoBus/httpEventSourceDemo",
diff --git a/adapter/api/src/main/java/org/apache/rocketmq/eventbridge/adapter/api/converter/HttpEventConverter.java b/adapter/api/src/main/java/org/apache/rocketmq/eventbridge/adapter/api/converter/HttpEventConverter.java
index 6e547ee..7e485ea 100644
--- a/adapter/api/src/main/java/org/apache/rocketmq/eventbridge/adapter/api/converter/HttpEventConverter.java
+++ b/adapter/api/src/main/java/org/apache/rocketmq/eventbridge/adapter/api/converter/HttpEventConverter.java
@@ -237,7 +237,7 @@ public class HttpEventConverter {
         httpEventData.setBody(bodyContent);
         httpEventData.setHeaders(dataHeaders);
         httpEventData.setHttpMethod(request.getMethod().toString());
-        httpEventData.setPath(request.getPath().toString());
+        httpEventData.setPath(request.getPath().pathWithinApplication().value());
 
         HashMap<String, String> queryParam = new HashMap<>();
         request.getQueryParams().forEach((k, v) -> {