You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jey <gi...@git.apache.org> on 2014/10/23 02:14:06 UTC
[GitHub] spark pull request: bash can't `die`
GitHub user jey opened a pull request:
https://github.com/apache/spark/pull/2898
bash can't `die`
This PR fixes the bug that `sbt/sbt` enters an infinite loop when a required argument is omitted:
```
jey@kallisti:~/proj/spark$ sbt/sbt -mem 2>&1 | head -n 10
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
/home/jey/proj/spark/sbt/sbt-launch-lib.bash: line 127: die: command not found
[...]
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jey/spark sbt-die-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2898.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2898
----
commit 55cfb6120b2d55ad13cd5e550b14e7a5c2938bdb
Author: Jey Kottalam <je...@kottalam.net>
Date: 2014-10-22T23:58:39Z
bash doesn't have "die"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by jey <gi...@git.apache.org>.
Github user jey commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-60192042
Hi @sarutak -- Yes, this issue does exist on `master` too. What's the recommended procedure here? I assumed it would just be rebased or cherry-picked onto `master` as part of the merge, but I'm not very familiar with the current merge protocols used by Spark. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2898
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-60176327
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22048/consoleFull) for PR 2898 at commit [`55cfb61`](https://github.com/apache/spark/commit/55cfb6120b2d55ad13cd5e550b14e7a5c2938bdb).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-62346030
@pwendell I've cherry-picked jey's change and open new PR #3182 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by jey <gi...@git.apache.org>.
Github user jey commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-62501777
Thanks @sarutak!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-62344714
I'd like to close this issue for now - but @jey we'd love a patch for this against master. it does appear broken!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-60182071
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22048/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-60288109
Hey @jey our preference is actually that you submit a pull request against master and then we backport it on our own. We have some tooling that makes this easy for us. Do you mind re-opening this agains master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-60182067
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22048/consoleFull) for PR 2898 at commit [`55cfb61`](https://github.com/apache/spark/commit/55cfb6120b2d55ad13cd5e550b14e7a5c2938bdb).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-60394077
(You should also make a JIRA when you change this PR to be against master)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: bash can't `die`
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2898#issuecomment-60181809
Hi @jey this issue is in master branch too. Can you also fix that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org