You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2018/09/03 12:16:35 UTC
Re: Review Request 68555: Made checker library retry to remove the
previous check container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68555/#review208259
-----------------------------------------------------------
Ship it!
Good catch and good fix, Qian!
- Alexander Rukletsov
On Aug. 29, 2018, 7:22 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68555/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 7:22 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, Gastón Kleiman, and Gilbert Song.
>
>
> Bugs: MESOS-8568
> https://issues.apache.org/jira/browse/MESOS-8568
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously when checker library fails to remove the previous check
> container, it will discard the promise and launch a new check container
> which will cause two problems:
> 1. The discarded promise is used to launch the new check container,
> that means even the new check container is launched successfully,
> we still have no chance to process its check result since the
> promise has already been discarded.
> 2. The previous check container will never get a chance to be removed
> which is leak, i.e., its runtime directory and sandbox directory
> will not be removed.
>
> Now in this patch, when checker library fails to remove the previous
> check container, we make it remove the previous check container again.
>
>
> Diffs
> -----
>
> src/checks/checker_process.cpp 77a76f465fe57eab89f027b5acb74c2339551678
>
>
> Diff: https://reviews.apache.org/r/68555/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>