You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2019/03/04 14:03:10 UTC
Review Request 70109: Added
`LinuxSeccompIsolatorTest.LaunchWithSeccompDisabled` test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70109/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Qian Zhang.
Bugs: MESOS-9613
https://issues.apache.org/jira/browse/MESOS-9613
Repository: mesos
Description
-------
This test verifies that Seccomp filtering can be disabled via
`unconfined` flag in `SeccompInfo` message. We create a Mesos
containerizer with a default Seccomp profile that prohibits
`uname` syscall. Then, `uname` command is launched with `unconfined`
flag set, so it's expected that the Seccomp filter does not affect
this command.
Diffs
-----
src/tests/containerizer/linux_seccomp_isolator_tests.cpp 1c4c3b1ea92bfbed37e599d6ad5dfd9cdcf9aea4
Diff: https://reviews.apache.org/r/70109/diff/1/
Testing
-------
`sudo src/mesos-tests --gtest_filter=LinuxSeccompIsolatorTest.*`
Thanks,
Andrei Budnik
Re: Review Request 70109: Added
`LinuxSeccompIsolatorTest.LaunchWithSeccompDisabled` test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70109/#review213400
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70108, 70109]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 4, 2019, 2:03 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70109/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 2:03 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-9613
> https://issues.apache.org/jira/browse/MESOS-9613
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that Seccomp filtering can be disabled via
> `unconfined` flag in `SeccompInfo` message. We create a Mesos
> containerizer with a default Seccomp profile that prohibits
> `uname` syscall. Then, `uname` command is launched with `unconfined`
> flag set, so it's expected that the Seccomp filter does not affect
> this command.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_seccomp_isolator_tests.cpp 1c4c3b1ea92bfbed37e599d6ad5dfd9cdcf9aea4
>
>
> Diff: https://reviews.apache.org/r/70109/diff/1/
>
>
> Testing
> -------
>
> `sudo src/mesos-tests --gtest_filter=LinuxSeccompIsolatorTest.*`
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70109: Added
`LinuxSeccompIsolatorTest.LaunchWithSeccompDisabled` test.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70109/#review213427
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 4, 2019, 6:03 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70109/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 6:03 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-9613
> https://issues.apache.org/jira/browse/MESOS-9613
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that Seccomp filtering can be disabled via
> `unconfined` flag in `SeccompInfo` message. We create a Mesos
> containerizer with a default Seccomp profile that prohibits
> `uname` syscall. Then, `uname` command is launched with `unconfined`
> flag set, so it's expected that the Seccomp filter does not affect
> this command.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_seccomp_isolator_tests.cpp 1c4c3b1ea92bfbed37e599d6ad5dfd9cdcf9aea4
>
>
> Diff: https://reviews.apache.org/r/70109/diff/1/
>
>
> Testing
> -------
>
> `sudo src/mesos-tests --gtest_filter=LinuxSeccompIsolatorTest.*`
>
>
> Thanks,
>
> Andrei Budnik
>
>