You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2008/01/06 20:07:13 UTC
[Bug 5766] New: sa-compile warnings
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5766
Summary: sa-compile warnings
Product: Spamassassin
Version: 3.2.4
Platform: Other
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P5
Component: sa-compile
AssignedTo: dev@spamassassin.apache.org
ReportedBy: maddoc@maddoc.net
sa-compile issues warnings when running:
body_0.xs: In function �XS_Mail__SpamAssassin__CompiledRegexps__body_0_scan�:
body_0.xs:131: warning: suggest parentheses around assignment used as truth value
body_0.xs:140: warning: suggest parentheses around assignment used as truth value
body_0.xs:149: warning: suggest parentheses around assignment used as truth value
body_0.xs:158: warning: suggest parentheses around assignment used as truth value
body_0.xs:167: warning: suggest parentheses around assignment used as truth value
body_0.xs:176: warning: suggest parentheses around assignment used as truth value
body_0.xs:185: warning: suggest parentheses around assignment used as truth value
body_0.xs:194: warning: suggest parentheses around assignment used as truth value
body_0.xs:203: warning: suggest parentheses around assignment used as truth value
body_0.xs:212: warning: suggest parentheses around assignment used as truth value
body_0.xs:221: warning: suggest parentheses around assignment used as truth value
body_0.xs:230: warning: suggest parentheses around assignment used as truth value
body_0.xs:239: warning: suggest parentheses around assignment used as truth value
body_0.xs:248: warning: suggest parentheses around assignment used as truth value
body_0.xs:257: warning: suggest parentheses around assignment used as truth value
body_0.xs:266: warning: suggest parentheses around assignment used as truth value
body_0.xs:275: warning: suggest parentheses around assignment used as truth value
body_0.xs:284: warning: suggest parentheses around assignment used as truth value
body_0.xs:114: warning: unused variable �i�
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5766] sa-compile warnings
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5766
------- Additional Comments From sidney@sidney.com 2008-01-06 11:31 -------
Here is a repeat of somethign I posted to the dev list about this:
I ran sa-compile --keep-tmps --sudo and can verify that in body_0.c there is
code that would produce those warnings if those warnings were enabled in the C
compilation. There are #line directives that would cause the warnings to say
"body_0.xs" as Doc showed, there are a number of lines of the form
while (match = Mail_SpamAssassin_CompiledRegexps_body_0_scan1 (&cursor))
which would generate a warning in case the '='is a typo for '==' and there is a
declaration 'int i;' but no use of variable 'i'.
So it appears that the difference is which warnings are enabled in the compiler
on our platforms using whatever command line sa-compile uses to compile.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5766] sa-compile warnings
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5766
------- Additional Comments From jm@jmason.org 2008-01-09 03:08 -------
I've just checked; these are already fixed in trunk:
PREINIT:
char *match;
unsigned char *cursor;
unsigned char *pstart;
unsigned char *pend;
STRLEN plen;
AV *results;
(no "int i")
cursor = pstart;
while (cursor < pend) {
while ((match = ${funcname} (\&cursor)) != NULL) {
split_and_add(results, match);
}
}
(note use of != NULL)
I'm not too pushed about backport to fix them in 3.2.x, but if anyone wants to
do that, go for it.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5766] sa-compile warnings
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5766
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Target Milestone|Undefined |3.3.0
------- Additional Comments From jm@jmason.org 2008-01-09 03:09 -------
marking FIXED (for now)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.