[GitHub] [activemq-artemis] brusdev commented on a change in pull request #2868: ARTEMIS-2466 PageSyncTimer::timeSync isn't configurable using ASYNCIO

[GitBox <gi...@apache.org>]

brusdev commented on a change in pull request #2868: ARTEMIS-2466 PageSyncTimer::timeSync isn't configurable using ASYNCIO
URL: https://github.com/apache/activemq-artemis/pull/2868#discussion_r338139668
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
 ##########
 @@ -675,6 +675,8 @@ public void parseMainConfig(final Element e, final Configuration config) throws
 
       config.setCriticalAnalyzerPolicy(CriticalAnalyzerPolicy.valueOf(getString(e, "critical-analyzer-policy", config.getCriticalAnalyzerPolicy().name(), Validators.NOT_NULL_OR_EMPTY)));
 
+      config.setPageSyncTimeout(getInteger(e, "page-sync-timeout", config.getJournalBufferTimeout_NIO(), Validators.GE_ZERO));
 
 Review comment:
   I'm sorry, I missed to commit the xsd file. I pushed a new commit to add the xsd file and some changes for the configuration tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services