You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/13 23:32:08 UTC

[GitHub] [arrow] rouault opened a new pull request #12619: Codec::GetCompressionType(): fix comment

rouault opened a new pull request #12619:
URL: https://github.com/apache/arrow/pull/12619


   Comment was wrong: compression strings are in lower case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12619: Codec::GetCompressionType(): fix comment

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12619:
URL: https://github.com/apache/arrow/pull/12619#issuecomment-1066207453


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12619: MINOR: [C++] Codec::GetCompressionType(): fix docstring

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12619:
URL: https://github.com/apache/arrow/pull/12619#issuecomment-1066884602


   Benchmark runs are scheduled for baseline = ece0e23f1fd5a2ab403e4a645ed01a9c257c0260 and contender = 5cb5afc40547b4f75739e31ff8632c71a10d3084. 5cb5afc40547b4f75739e31ff8632c71a10d3084 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5bfb0056788b491ab430823a4dcff08c...506f0446281942c0958b68df2ef20e55/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5df97e89ead4b65a33609e6c59fb8c5...71f9fee4c7d14bb589bacb2e4a95f605/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9cc426272df7444b8a30fcdafd833090...2cffd91b5ca14a20b5df0d0bf5ee7ae9/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30059c66dd5f4b1790577583cd9ec379...64116ccec5c34c50b0443a90f06214ec/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou closed pull request #12619: MINOR: [C++] Codec::GetCompressionType(): fix docstring

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12619:
URL: https://github.com/apache/arrow/pull/12619


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12619: MINOR: [C++] Codec::GetCompressionType(): fix docstring

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12619:
URL: https://github.com/apache/arrow/pull/12619#issuecomment-1066884602


   Benchmark runs are scheduled for baseline = ece0e23f1fd5a2ab403e4a645ed01a9c257c0260 and contender = 5cb5afc40547b4f75739e31ff8632c71a10d3084. 5cb5afc40547b4f75739e31ff8632c71a10d3084 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5bfb0056788b491ab430823a4dcff08c...506f0446281942c0958b68df2ef20e55/)
   [Finished :arrow_down:0.04% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5df97e89ead4b65a33609e6c59fb8c5...71f9fee4c7d14bb589bacb2e4a95f605/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9cc426272df7444b8a30fcdafd833090...2cffd91b5ca14a20b5df0d0bf5ee7ae9/)
   [Finished :arrow_down:0.89% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30059c66dd5f4b1790577583cd9ec379...64116ccec5c34c50b0443a90f06214ec/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12619: MINOR: [C++] Codec::GetCompressionType(): fix docstring

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12619:
URL: https://github.com/apache/arrow/pull/12619#issuecomment-1066884602


   Benchmark runs are scheduled for baseline = ece0e23f1fd5a2ab403e4a645ed01a9c257c0260 and contender = 5cb5afc40547b4f75739e31ff8632c71a10d3084. 5cb5afc40547b4f75739e31ff8632c71a10d3084 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5bfb0056788b491ab430823a4dcff08c...506f0446281942c0958b68df2ef20e55/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5df97e89ead4b65a33609e6c59fb8c5...71f9fee4c7d14bb589bacb2e4a95f605/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9cc426272df7444b8a30fcdafd833090...2cffd91b5ca14a20b5df0d0bf5ee7ae9/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30059c66dd5f4b1790577583cd9ec379...64116ccec5c34c50b0443a90f06214ec/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12619: MINOR: [C++] Codec::GetCompressionType(): fix docstring

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12619:
URL: https://github.com/apache/arrow/pull/12619#issuecomment-1066884602


   Benchmark runs are scheduled for baseline = ece0e23f1fd5a2ab403e4a645ed01a9c257c0260 and contender = 5cb5afc40547b4f75739e31ff8632c71a10d3084. 5cb5afc40547b4f75739e31ff8632c71a10d3084 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5bfb0056788b491ab430823a4dcff08c...506f0446281942c0958b68df2ef20e55/)
   [Finished :arrow_down:0.04% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5df97e89ead4b65a33609e6c59fb8c5...71f9fee4c7d14bb589bacb2e4a95f605/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9cc426272df7444b8a30fcdafd833090...2cffd91b5ca14a20b5df0d0bf5ee7ae9/)
   [Finished :arrow_down:0.89% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30059c66dd5f4b1790577583cd9ec379...64116ccec5c34c50b0443a90f06214ec/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12619: MINOR: [C++] Codec::GetCompressionType(): fix docstring

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12619:
URL: https://github.com/apache/arrow/pull/12619#issuecomment-1066884602


   Benchmark runs are scheduled for baseline = ece0e23f1fd5a2ab403e4a645ed01a9c257c0260 and contender = 5cb5afc40547b4f75739e31ff8632c71a10d3084. 5cb5afc40547b4f75739e31ff8632c71a10d3084 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5bfb0056788b491ab430823a4dcff08c...506f0446281942c0958b68df2ef20e55/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5df97e89ead4b65a33609e6c59fb8c5...71f9fee4c7d14bb589bacb2e4a95f605/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9cc426272df7444b8a30fcdafd833090...2cffd91b5ca14a20b5df0d0bf5ee7ae9/)
   [Finished :arrow_down:0.89% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30059c66dd5f4b1790577583cd9ec379...64116ccec5c34c50b0443a90f06214ec/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org