You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by fu...@apache.org on 2013/01/10 10:17:18 UTC

svn commit: r1431215 - /httpd/httpd/branches/2.4.x/STATUS

Author: fuankg
Date: Thu Jan 10 09:17:18 2013
New Revision: 1431215

URL: http://svn.apache.org/viewvc?rev=1431215&view=rev
Log:
vote.

Modified:
    httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1431215&r1=1431214&r2=1431215&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Thu Jan 10 09:17:18 2013
@@ -104,6 +104,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
       2.4.x patch: http://www.humbedooh.com/apache/lua_dbd.patch
                    + CHANGES
       +1: humbedooh
+      -1: fuankg - we 1st need some workarounds for stupid CodeWarrior compiler.
       
    * configure --with-modules:
      - Fix shell errors when trying to AC_MSG_RESULT().



Re: svn commit: r1431215 - /httpd/httpd/branches/2.4.x/STATUS

Posted by Gregg Smith <gl...@gknw.net>.
On 1/10/2013 1:33 PM, Gregg Smith wrote:
>
> Your 2.4 patch seems to be missing this part of r1430225
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/mod_lua.dsp?r1=1430225&r2=1430224&pathrev=1430225 
>
>

This is also needed
http://svn.apache.org/viewvc?view=revision&revision=1431681

Re: svn commit: r1431215 - /httpd/httpd/branches/2.4.x/STATUS

Posted by Daniel Gruno <ru...@cord.dk>.
On 01/10/2013 10:33 PM, Gregg Smith wrote:
> 
> On a side note there's this, not sure how long that's been there, it
> just seems wrong not having a 'case' return something.
> c:\build2\httpd-2.4.x_r1431331\modules\lua\mod_lua.c(110) : warning
> C4715: 'scope_to_string' : not all control paths return a value
> 
> Cheers,
> 
> Gregg
That's been fixed in trunk with r1422373, just fyi (though probably not
just backportable, as it was part of a larger fix to trunk code).
It's not a real issue though, but yeah, it doesn't hurt to make
compilers happy (most of the time).

With regards,
Daniel.

Re: svn commit: r1431215 - /httpd/httpd/branches/2.4.x/STATUS

Posted by Daniel Gruno <ru...@cord.dk>.
On 01/10/2013 10:33 PM, Gregg Smith wrote:
> Hi Daniel,
> 
> On 1/10/2013 4:55 AM, Daniel Gruno wrote:
>> On 01/10/2013 01:52 PM, Guenter Knauf wrote:
>>> Hi Daniel,
>>> Am 10.01.2013 10:34, schrieb Daniel Gruno:
>>>> Can you provide me with the errors that it produces, or some tips on
>>>> how
>>>> I can possibly run this compiler on my own computer? Otherwise, I
>>>> really
>>>> don't know what to do here - the bindings work fine on all the machines
>>>> I've tested them on.
> 
> Unfortunately, all the lua_pushcfunctions are nightmarish on Windows from
> .\lua_dbd.c(662) : error C2440: 'function' : cannot convert from 'int
> (__stdcall *)(lua_State *)' to 'lua_CFunction'
> to
> .\lua_dbd.c(692) : error C2440: 'function' : cannot convert from 'int
> (__stdcall *)(lua_State *)' to 'lua_CFunction'
> Casting the int function to lua_CFunction seems to work.
> 
> Your 2.4 patch seems to be missing this part of r1430225
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/mod_lua.dsp?r1=1430225&r2=1430224&pathrev=1430225
> 
> 
> On a side note there's this, not sure how long that's been there, it
> just seems wrong not having a 'case' return something.
> c:\build2\httpd-2.4.x_r1431331\modules\lua\mod_lua.c(110) : warning
> C4715: 'scope_to_string' : not all control paths return a value
> 
> Cheers,
> 
> Gregg
Why can't we just make httpd run on UNIX and say that that's it ;)
sigh, I guess I have to do some more work on this ting today,
thanks for letting me know :) It's appreciated that people actually try
these things out and give such good feedback as is given on the http
project.

With regards,
Daniel.

Re: svn commit: r1431215 - /httpd/httpd/branches/2.4.x/STATUS

Posted by Gregg Smith <gl...@gknw.net>.
Hi Daniel,

On 1/10/2013 4:55 AM, Daniel Gruno wrote:
> On 01/10/2013 01:52 PM, Guenter Knauf wrote:
>> Hi Daniel,
>> Am 10.01.2013 10:34, schrieb Daniel Gruno:
>>> Can you provide me with the errors that it produces, or some tips on how
>>> I can possibly run this compiler on my own computer? Otherwise, I really
>>> don't know what to do here - the bindings work fine on all the machines
>>> I've tested them on.

Unfortunately, all the lua_pushcfunctions are nightmarish on Windows from
.\lua_dbd.c(662) : error C2440: 'function' : cannot convert from 'int 
(__stdcall *)(lua_State *)' to 'lua_CFunction'
to
.\lua_dbd.c(692) : error C2440: 'function' : cannot convert from 'int 
(__stdcall *)(lua_State *)' to 'lua_CFunction'
Casting the int function to lua_CFunction seems to work.

Your 2.4 patch seems to be missing this part of r1430225
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/mod_lua.dsp?r1=1430225&r2=1430224&pathrev=1430225

On a side note there's this, not sure how long that's been there, it 
just seems wrong not having a 'case' return something.
c:\build2\httpd-2.4.x_r1431331\modules\lua\mod_lua.c(110) : warning 
C4715: 'scope_to_string' : not all control paths return a value

Cheers,

Gregg

Re: svn commit: r1431215 - /httpd/httpd/branches/2.4.x/STATUS

Posted by Daniel Gruno <ru...@cord.dk>.
On 01/10/2013 01:52 PM, Guenter Knauf wrote:
> Hi Daniel,
> Am 10.01.2013 10:34, schrieb Daniel Gruno:
>> Can you provide me with the errors that it produces, or some tips on how
>> I can possibly run this compiler on my own computer? Otherwise, I really
>> don't know what to do here - the bindings work fine on all the machines
>> I've tested them on.
> meanwhile all clarfied; I was writing the mail to you just after I did
> mention the prob in STATUS;
> just wanted to avoid that the backport takes place without a workaround.
> Thanks for your quick coding!
> 
> Gün.
> 
> 
Yeah, it did seem a bit funny that those emails arrived at about the
same time. I've done some "manual" pushing of functions now, that work
just as well - the 3D array was really just a convenient way of pushing
everything, and a standard Lua-C practice. Hopefully we won't get any
more compiler errors :)

With regards,
Daniel.

Re: svn commit: r1431215 - /httpd/httpd/branches/2.4.x/STATUS

Posted by Guenter Knauf <fu...@apache.org>.
Hi Daniel,
Am 10.01.2013 10:34, schrieb Daniel Gruno:
> Can you provide me with the errors that it produces, or some tips on how
> I can possibly run this compiler on my own computer? Otherwise, I really
> don't know what to do here - the bindings work fine on all the machines
> I've tested them on.
meanwhile all clarfied; I was writing the mail to you just after I did 
mention the prob in STATUS;
just wanted to avoid that the backport takes place without a workaround.
Thanks for your quick coding!

Gün.



Re: svn commit: r1431215 - /httpd/httpd/branches/2.4.x/STATUS

Posted by Daniel Gruno <ru...@cord.dk>.
On 01/10/2013 10:17 AM, fuankg@apache.org wrote:
> Author: fuankg
> Date: Thu Jan 10 09:17:18 2013
> New Revision: 1431215
> 
> URL: http://svn.apache.org/viewvc?rev=1431215&view=rev
> Log:
> vote.
> 
> Modified:
>     httpd/httpd/branches/2.4.x/STATUS
> 
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1431215&r1=1431214&r2=1431215&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Thu Jan 10 09:17:18 2013
> @@ -104,6 +104,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>        2.4.x patch: http://www.humbedooh.com/apache/lua_dbd.patch
>                     + CHANGES
>        +1: humbedooh
> +      -1: fuankg - we 1st need some workarounds for stupid CodeWarrior compiler.
>        
>     * configure --with-modules:
>       - Fix shell errors when trying to AC_MSG_RESULT().
> 
> 
How am I supposed to write a workaround for a compiler I apparently
can't run on any of my computers (and also have to pay for?)?

Can you provide me with the errors that it produces, or some tips on how
I can possibly run this compiler on my own computer? Otherwise, I really
don't know what to do here - the bindings work fine on all the machines
I've tested them on.

With regards,
Daniel.