You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by 10110346 <gi...@git.apache.org> on 2018/08/10 08:32:15 UTC

[GitHub] spark pull request #22068: [MINOR][DOC]Add missing compression codec .

GitHub user 10110346 opened a pull request:

    https://github.com/apache/spark/pull/22068

    [MINOR][DOC]Add missing compression codec .

    ## What changes were proposed in this pull request?
    
    Parquet file provides six codecs: "snappy", "gzip", "lzo", "lz4", "brotli", "zstd". 
    This pr add missing compression codec :"lz4", "brotli", "zstd" .
    ## How was this patch tested?
    N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/10110346/spark nosupportlz4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22068.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22068
    
----
commit 74aa80cb63c6ea98f0b9106f0724748931317c05
Author: liuxian <li...@...>
Date:   2018-08-09T07:22:01Z

    fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2066/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by kiszk <gi...@git.apache.org>.

Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Would it be better to update a comment in `DataFrameWriter.scala`, too?
    
    ```
       * <li>`compression` (default is the value specified in `spark.sql.parquet.compression.codec`):
       * compression codec to use when saving to file. This can be one of the known case-insensitive
       * shorten names(`none`, `snappy`, `gzip`, and `lzo`). This will override
       * `spark.sql.parquet.compression.codec`.</li>
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    **[Test build #94605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94605/testReport)** for PR 22068 at commit [`5b4562a`](https://github.com/apache/spark/commit/5b4562a19e1b29a2d0d20f4b046c88837c536dac).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94550/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2074/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by kiszk <gi...@git.apache.org>.

Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Thanks. BTW, I found another instance in test, not in doc.
    
    Do we address this in this PR?  Or, do we address in another PR?
    @HyukjinKwon  WDYT ?
    
    ```
    class ParquetCompressionCodecPrecedenceSuite extends ParquetTest with SharedSQLContext {
      test("Test `spark.sql.parquet.compression.codec` config") {
        Seq("NONE", "UNCOMPRESSED", "SNAPPY", "GZIP", "LZO").foreach { c =>
          withSQLConf(SQLConf.PARQUET_COMPRESSION.key -> c) {
            val expected = if (c == "NONE") "UNCOMPRESSED" else c
            val option = new ParquetOptions(Map.empty[String, String], spark.sessionState.conf)
            assert(option.compressionCodecClassName == expected)
          }
        }
      }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by 10110346 <gi...@git.apache.org>.

Github user 10110346 commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    I will update,thanks @kiszk @HyukjinKwon 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    **[Test build #94605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94605/testReport)** for PR 22068 at commit [`5b4562a`](https://github.com/apache/spark/commit/5b4562a19e1b29a2d0d20f4b046c88837c536dac).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by 10110346 <gi...@git.apache.org>.

Github user 10110346 commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94605/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2065/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    **[Test build #94550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94550/testReport)** for PR 22068 at commit [`74aa80c`](https://github.com/apache/spark/commit/74aa80cb63c6ea98f0b9106f0724748931317c05).
     * This patch **fails SparkR unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    **[Test build #94550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94550/testReport)** for PR 22068 at commit [`74aa80c`](https://github.com/apache/spark/commit/74aa80cb63c6ea98f0b9106f0724748931317c05).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Yea, if there are more instances found, we better fix them together while we are here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94594/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    **[Test build #4237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4237/testReport)** for PR 22068 at commit [`74aa80c`](https://github.com/apache/spark/commit/74aa80cb63c6ea98f0b9106f0724748931317c05).
     * This patch **fails SparkR unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94593/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    **[Test build #94593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94593/testReport)** for PR 22068 at commit [`59f6080`](https://github.com/apache/spark/commit/59f6080030fddece04f5e8cda0a27b6aa60393a6).
     * This patch **fails Python style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22068: [MINOR][DOC]Add missing compression codec .

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22068
  
    Eh, I think it's okay. Let's just get this in.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org