[GitHub] mistercrunch edited a comment on issue #5747: Jinja template + dataframe access from Separator'esque Viz

[GitBox <gi...@apache.org>]

mistercrunch edited a comment on issue #5747: Jinja template + dataframe access from Separator'esque Viz
URL: https://github.com/apache/incubator-superset/issues/5747#issuecomment-419142785
 
 
   One limitation here is having the ability to mix data from different datasources. I'm wondering if we should have something more like:
   ```
   {% set df = run_sql('SELECT sum(units) AS units FROM sales') %}
   We sold a total of <strong>{{ df['units'][0] }}</string> units
   ```
   To allow for multiple queries / datasources.
   
   A few other considerations:
   * should this be a feature of the markdown dashboard-native component?
   * Should this be more of a client-side templating? Meaning you could see the text right away and loading spinners within the text while the async calls are happening. I think Jinja is probably fine easier and opens the power of pandas...
   * clearly some security concerns here, we should probably make this viz type unavailable by default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org