You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/28 11:20:46 UTC

[GitHub] [incubator-nuttx-apps] normanr opened a new pull request #943: Update PWM example to handle extra channels

normanr opened a new pull request #943:
URL: https://github.com/apache/incubator-nuttx-apps/pull/943


   ## Summary
   - Increase number of supported PWM channels from 4 to 6 and add an error if the number of channels is greater than 6
   - Adjust channel and duty bounds to allow testing sentinel values
   - Use macros from `fixedmath.h` for manipulating duty cycle to avoid magic shift logic in code (no change to behavior)
   
   ## Impact
   The PWM example app can now be used to test more channels and sentinel values for channel and duty.
   
   ## Testing
   Run the example app via nsh using a board with a bl602 chipset


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #943: Update PWM example to handle extra channels

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #943:
URL: https://github.com/apache/incubator-nuttx-apps/pull/943


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] normanr commented on pull request #943: Update PWM example to handle extra channels

Posted by GitBox <gi...@apache.org>.
normanr commented on pull request #943:
URL: https://github.com/apache/incubator-nuttx-apps/pull/943#issuecomment-1002540625


   > @normanr some style issue need fixed: https://github.com/apache/incubator-nuttx-apps/runs/4657076135?check_suite_focus=true
   
   Fixed. I'd been working to 78 characters, and that line was exactly that. I removed the extra whitespace before the equals sign to get it to fix. (I also removed some from the lower lines because there was unnecessary extra whitespace there too.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #943: Update PWM example to handle extra channels

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #943:
URL: https://github.com/apache/incubator-nuttx-apps/pull/943#issuecomment-1002477872


   @normanr some style issue need fixed:
   https://github.com/apache/incubator-nuttx-apps/runs/4657076135?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org