[GitHub] [pulsar] codelipenghui commented on a change in pull request #12970: [PIP-105] Part-2 Support pluggable entry filter in Dispatcher

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #12970:
URL: https://github.com/apache/pulsar/pull/12970#discussion_r756625685



##########
File path: conf/broker.conf
##########
@@ -411,6 +411,11 @@ dispatcherReadFailureBackoffMandatoryStopTimeInMs=0
 # Precise dispathcer flow control according to history message number of each entry
 preciseDispatcherFlowControl=false
 
+# Class name of Pluggable entry filter that can decide whether the entry needs to be filtered
+# You can use this class to decide which entries can be sent to consumers.
+# Multiple classes need to be separated by commas.
+entryFilterClassNames=

Review comment:
       Do we need a directory to maintain all the filters? otherwise, we need to copy the filter jar to the lib dir.

##########
File path: conf/broker.conf
##########
@@ -411,6 +411,11 @@ dispatcherReadFailureBackoffMandatoryStopTimeInMs=0
 # Precise dispathcer flow control according to history message number of each entry
 preciseDispatcherFlowControl=false
 
+# Class name of Pluggable entry filter that can decide whether the entry needs to be filtered
+# You can use this class to decide which entries can be sent to consumers.
+# Multiple classes need to be separated by commas.
+entryFilterClassNames=

Review comment:
       Another point is we should load the class by a separate classloader that extends from the pulsar classloader?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org