You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 18:25:03 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2296: Simplify sort streams

tustvold commented on code in PR #2296:
URL: https://github.com/apache/arrow-datafusion/pull/2296#discussion_r854432161


##########
datafusion/core/src/physical_plan/sorts/sort_preserving_merge.rs:
##########
@@ -196,16 +197,23 @@ impl ExecutionPlan for SortPreservingMergeExec {
                             part_i,
                             context.clone(),
                         );
-                        (receiver, join_handle)
+
+                        SortedStream::new(
+                            RecordBatchReceiverStream::create(
+                                &schema,
+                                receiver,
+                                join_handle,
+                            ),
+                            0,

Review Comment:
   I think specifying 0 here is ok, but perhaps @yjshen could confirm?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org