You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/02/26 21:39:37 UTC

[GitHub] [camel-website] zregvart commented on issue #163: Pr/algolia search

zregvart commented on issue #163: Pr/algolia search
URL: https://github.com/apache/camel-website/pull/163#issuecomment-591657888
 
 
   Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-163/Preview/). I think we could do with a bit of styling on the search results, currently it looks like this:
   
   ![Screenshot_2020-02-26 https builds apache org](https://user-images.githubusercontent.com/1306050/75389975-c68c6200-58e7-11ea-85f3-4820c948e76e.png)
   
   There's also an error that gets logged in the browser console:
   
   ```
   TypeError: n._snippetResult is undefined
   ```
   
   It's good to see that the V4 of the Algolia search JavaScript is only 4.8KB (previous was 100+KB). I don't think it would load on the website due to content security policy:
   
   https://github.com/apache/camel-website/blob/d35d9e3be385a7a4bdf958a7b28d8a2bfaa15999/static/.htaccess#L1326
   
   We need to serve the resources from the same server, that would mean that we need to build/bundle with the theme (IIRC).
   
   I wonder why we don't get the component reference indexed, I think in the end the best outcome for us would be to generate the index ourselves, but this is a good start.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services