You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/03/10 12:34:57 UTC

[GitHub] [incubator-skywalking] wu-sheng edited a comment on issue #2292: mysql-8x-plugin and multihost support for mysql5.x

wu-sheng edited a comment on issue #2292: mysql-8x-plugin and multihost support for mysql5.x
URL: https://github.com/apache/incubator-skywalking/pull/2292#issuecomment-471279051
 
 
   ~~If you are saying the duplicate interceptor codes(I don't read all codes) and separate plugin versions, then, I think these are right calls~~
   ~~1. Create mysql-common module for duplicate codes~~
   ~~2. Create 5, 6, 8 mysql plugin modules, and place the right instrument declarations in there.~~
   
   ~~@dsc6636926 Any concern for this change?~~
   
   ~~@ascrutae make sense?~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services