[GitHub] [incubator-inlong] LvJiancheng commented on a diff in pull request #4211: [INLONG-4197][Manager] Add Hbase sink info and load node utils

[GitBox <gi...@apache.org>]

LvJiancheng commented on code in PR #4211:
URL: https://github.com/apache/incubator-inlong/pull/4211#discussion_r875582608


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/LoadNodeUtils.java:
##########
@@ -161,6 +165,44 @@ public static HiveLoadNode createLoadNode(HiveSinkResponse hiveSinkResponse) {
         );
     }
 
+    public static HbaseLoadNode createLoadNode(HbaseSinkResponse hbaseSinkResponse) {

Review Comment:
   done



##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/hbase/HbaseSinkDTO.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.common.pojo.sink.hbase;
+
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.Data;
+import lombok.NoArgsConstructor;
+import org.apache.inlong.manager.common.enums.ErrorCodeEnum;
+import org.apache.inlong.manager.common.exceptions.BusinessException;
+
+import javax.validation.constraints.NotNull;
+import java.util.Map;
+
+/**
+ * Hbase sink info
+ */
+@Data
+@Builder
+@NoArgsConstructor
+@AllArgsConstructor
+public class HbaseSinkDTO {
+
+    private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+
+    @ApiModelProperty("Target table name")
+    private String tableName;
+
+    @ApiModelProperty("Namespace")
+    private String nameSpace;
+
+    @ApiModelProperty("Row key")
+    private String rowKey;
+
+    @ApiModelProperty("Zookeeper quorm")
+    private String zookeeperQuorum;
+
+    @ApiModelProperty("Sink buffer flush maxsize")
+    private String sinkBufferFlushMaxSize;
+
+    @ApiModelProperty("Zookeeper znode parent")
+    private String zookeeperZnodeParent;
+
+    @ApiModelProperty("Sink buffer flush max rows")
+    private String sinkBufferFlushMaxRows;
+
+    @ApiModelProperty("Sink buffer flush interval")
+    private String sinkBufferFlushInterval;
+
+    @ApiModelProperty("Properties for hbase")
+    private Map<String, Object> properties;
+
+    /**
+     * Get the dto instance from the request
+     */
+    public static HbaseSinkDTO getFromRequest(HbaseSinkRequest request) {
+        return HbaseSinkDTO.builder()
+                .tableName(request.getTableName())
+                .nameSpace(request.getNameSpace())
+                .rowKey(request.getRowKey())
+                .zookeeperQuorum(request.getZookeeperQuorum())
+                .sinkBufferFlushMaxSize(request.getSinkBufferFlushMaxSize())
+                .zookeeperZnodeParent(request.getZookeeperZnodeParent())
+                .sinkBufferFlushMaxRows(request.getSinkBufferFlushMaxRows())
+                .sinkBufferFlushInterval(request.getSinkBufferFlushInterval())
+                .properties(request.getProperties())
+                .build();
+    }
+
+    public static HbaseSinkDTO getFromJson(@NotNull String extParams) {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org