You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by Enrico Olivelli <eo...@gmail.com> on 2022/08/11 07:51:38 UTC

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

Il Sab 23 Lug 2022, 03:26 Yan Zhao <ho...@apache.org> ha scritto:

> Yes, wo define `twoPhaseDeletionEnabled` in the Service Configuration.
>

Thanks.

I suggest to include 'topic' in the flag,  we have too many entities in
Pulsar


Enrico

>

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

Posted by Yan Zhao <ho...@apache.org>.

Good idea.

> Good idea. I suggest the naming endings with `Seconds` like
> sendDelayOfTwoPhaseDeletionInSeconds,`
> reconsumeLaterOfTwoPhaseDeletionInSeconds`.
> >    private int sendDelaySecondsOfTwoPhaseDeletion = 60;
> >    private int reconsumeLaterSecondsOfTwoPhaseDeletion = 600;

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

Posted by Qiang Huang <qi...@gmail.com>.

Good idea. I suggest the naming endings with `Seconds` like
sendDelayOfTwoPhaseDeletionInSeconds,`
reconsumeLaterOfTwoPhaseDeletionInSeconds`.
>    private int sendDelaySecondsOfTwoPhaseDeletion = 60;
>    private int reconsumeLaterSecondsOfTwoPhaseDeletion = 600;

Yan Zhao <ho...@apache.org> 于2022年8月12日周五 10:45写道：

> > I suggest to include 'topic' in the flag,  we have too many entities in
> > Pulsar
>
> Thanks, change it to `topicTwoPhaseDeletionEnabled`.
>


-- 
BR,
Qiang Huang

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

Posted by Yan Zhao <ho...@apache.org>.

> I suggest to include 'topic' in the flag,  we have too many entities in
> Pulsar

Thanks, change it to `topicTwoPhaseDeletionEnabled`.